[ovs-dev] [PATCH] ovsdb: Catch negative timeout values

Ben Pfaff blp at nicira.com
Wed Aug 27 14:48:43 UTC 2014

On Wed, Aug 27, 2014 at 12:41:50AM +0200, Thomas Graf wrote:
> Although the check is present already, a missing !error branch
> in the next condition prevents the error from being reported back.
> Signed-off-by: Thomas Graf <tgraf at noironetworks.com>

Are you sure?  I think that the only real bug here is that if the
timeout is negative *and* the "until" string is invalid, then there's a
memory leak of the error message for the negative timeout.  We should
still fix that, and the same code change does that, but I think that the
commit message is wrong.

More information about the dev mailing list