[ovs-dev] [PATCH 15/18] ofproto/netflow: Use atomic_count for 'netflow_count'.

Ben Pfaff blp at nicira.com
Thu Aug 28 19:18:30 UTC 2014


On Fri, Aug 22, 2014 at 01:58:26PM -0700, Jarno Rajahalme wrote:
> 'netflow_count' and the existence of actual netflow objects is not
> tightly synchronized, so we can use the relaxed atomic_count for it.
> 
> Signed-off-by: Jarno Rajahalme <jrajahalme at nicira.com>

...

> -/* Returns true if there exist any netflow objects, false otherwise. */
> +/* Returns true if there exist any netflow objects, false otherwise.
> + * Callers can cope with transient false positives, i.e., there is no tight
> + * synchronization with the count and the actual existence of netflow objects.
> + */

I think I'd be more inclined to say that callers "must" cope with
false positives.

Acked-by: Ben Pfaff <blp at nicira.com>



More information about the dev mailing list