[ovs-dev] [PATCH 7/9 v2] datapath-windows: add clarifications to markers in dump state

Nithin Raju nithin at vmware.com
Fri Aug 29 08:15:19 UTC 2014


Signed-off-by: Nithin Raju <nithin at vmware.com>
Acked-by: Ankur Sharma <ankursharma at vmware.com>
Acked-by: Samuel Ghinet <sghinet at cloudbasesolutions.com>
---
 datapath-windows/ovsext/Datapath.h |   10 ++++++----
 1 files changed, 6 insertions(+), 4 deletions(-)

diff --git a/datapath-windows/ovsext/Datapath.h b/datapath-windows/ovsext/Datapath.h
index d0b6d19..8d69f09 100644
--- a/datapath-windows/ovsext/Datapath.h
+++ b/datapath-windows/ovsext/Datapath.h
@@ -70,8 +70,10 @@ typedef struct _OVS_OPEN_INSTANCE {
 
     struct {
         POVS_MESSAGE ovsMsg;    /* OVS message passed during dump start. */
-        UINT32 index[8];        /* markers to continue dump from. One or more
-                                 * of them may be used. */
+        UINT32 index[2];        /* markers to continue dump from. One or more
+                                 * of them may be used. Eg. in flow dump, the
+                                 * markers can store the row and the column
+                                 * indices. */
     } dumpState;                /* data to support dump commands. */
 } OVS_OPEN_INSTANCE, *POVS_OPEN_INSTANCE;
 
@@ -129,8 +131,8 @@ InitUserDumpState(POVS_OPEN_INSTANCE instance,
     ASSERT(instance->dumpState.ovsMsg == NULL);
     ASSERT(ovsMsg);
 
-    instance->dumpState.ovsMsg = (POVS_MESSAGE) OvsAllocateMemory(
-        sizeof *instance->dumpState.ovsMsg);
+    instance->dumpState.ovsMsg =
+        (POVS_MESSAGE) OvsAllocateMemory(sizeof (OVS_MESSAGE));
     if (instance->dumpState.ovsMsg == NULL) {
         return STATUS_NO_MEMORY;
     }
-- 
1.7.4.1




More information about the dev mailing list