[ovs-dev] [PATCH 8/9 v3] datpath-windows: fix the dp index check in ValidateNetlinkCmd()

Ankur Sharma ankursharma at vmware.com
Fri Aug 29 19:05:05 UTC 2014


Also renamed the validateDp boolean to a more meaningful name.

Signed-off-by: Nithin Raju <nithin at vmware.com>
Signed-off-by: Ankur Sharma <ankursharma at vmware.com>
Acked-by: Ankur Sharma <ankursharma at vmware.com>
---
Please attribute this to Nithin Raju <nithin at vmware.com>
---
 datapath-windows/ovsext/Datapath.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/datapath-windows/ovsext/Datapath.c b/datapath-windows/ovsext/Datapath.c
index 7103764..ccb69e3 100644
--- a/datapath-windows/ovsext/Datapath.c
+++ b/datapath-windows/ovsext/Datapath.c
@@ -71,7 +71,7 @@ typedef struct _NETLINK_CMD {
     UINT16 cmd;
     NetlinkCmdHandler handler;
     UINT32 supportedDevOp;      /* Supported device operations. */
-    BOOLEAN validateDp;         /* Does command require a valid DP argument. */
+    BOOLEAN validateDpIndex;    /* Does command require a valid DP argument. */
 } NETLINK_CMD, *PNETLINK_CMD;
 
 /* A netlink family is a group of commands. */
@@ -726,9 +726,9 @@ ValidateNetlinkCmd(UINT32 devOp,
             }
 
             /* Validate the DP for commands that require a DP. */
-            if (nlFamilyOps->cmds[i].validateDp == TRUE) {
+            if (nlFamilyOps->cmds[i].validateDpIndex == TRUE) {
                 OvsAcquireCtrlLock();
-                if (ovsMsg->ovsHdr.dp_ifindex ==
+                if (ovsMsg->ovsHdr.dp_ifindex !=
                     (INT)gOvsSwitchContext->dpNo) {
                     status = STATUS_INVALID_PARAMETER;
                     OvsReleaseCtrlLock();
-- 
1.8.3.2




More information about the dev mailing list