[ovs-dev] [PATCH 9/9 v2] datapath-windows: refactor code to setup dump start state

Ankur Sharma ankursharma at vmware.com
Fri Aug 29 20:38:06 UTC 2014


Hi Ben,

Thank you so much for the reply. 
No problem @ all, i can merge the review comments in original series of 4 patches.

I'll send a v4 soon.

Regards,
Ankur
________________________________________
From: Ben Pfaff <blp at nicira.com>
Sent: Friday, August 29, 2014 1:30 PM
To: Ankur Sharma
Cc: Eitan Eliahu; Samuel Ghinet; dev at openvswitch.org; Nithin Raju
Subject: Re: [ovs-dev] [PATCH 9/9 v2] datapath-windows: refactor code to setup dump start state

On Fri, Aug 29, 2014 at 07:11:41PM +0000, Ankur Sharma wrote:
> I have talked to ben and he is fine with the approach of handling
> the review comment in another patch in the same series. But yes
> ideally we should try to keep the review comment fix in the same
> patch.

Is this just a matter of squashing some patches together?  i.e. can
you just run "git rebase -i origin/master" to fix up the issues?  If
so then I'd also prefer to see the comments handled as part of the
original patch.

Basically, is it for some reason *difficult* to fix up the original
patch?  I doubt it; many of the OVS contributors do this routinely.



More information about the dev mailing list