[ovs-dev] [PATCH v2 1/3] lib/seq: Document acquire-release semantics.

Jarno Rajahalme jrajahalme at nicira.com
Fri Aug 29 23:21:52 UTC 2014


On Aug 29, 2014, at 2:31 PM, Ben Pfaff <blp at nicira.com> wrote:

> On Fri, Aug 29, 2014 at 02:10:42PM -0700, Jarno Rajahalme wrote:
>> Seq objects would be really hard to use if they did not provide
>> acquire-release semantics.  Currently they do that via
>> ovs_mutex_lock()/ovs_mutex_unlock(), respectively.  Document the
>> behavior so that it is safer to rely on that elsewhere.
>> 
>> Signed-off-by: Jarno Rajahalme <jrajahalme at nicira.com>
> 
> Only one thread calls seq_change() but every thread calls seq_read(),
> so I'd expect that it's seq_read that really does the synchronization
> here.  Anyway, with that one quibble I'm happy with this, thanks.
> 

I changed the comment accordingly and pushed the series. Thanks for the reviews, and have a nice long weekend!

  Jarno

> Acked-by: Ben Pfaff <blp at nicira.com>




More information about the dev mailing list