[ovs-dev] [PATCH] net: openvswitch: Support masked set actions.

Jesse Gross jesse at nicira.com
Thu Dec 11 02:03:47 UTC 2014


On Tue, Dec 9, 2014 at 4:10 PM, Jarno Rajahalme <jrajahalme at nicira.com> wrote:
> diff --git a/net/openvswitch/flow_netlink.c b/net/openvswitch/flow_netlink.c
> index df3c7f2..276bb60 100644
> --- a/net/openvswitch/flow_netlink.c
> +++ b/net/openvswitch/flow_netlink.c
> @@ -2007,6 +2117,18 @@ int ovs_nla_put_actions(const struct nlattr *attr, int len, struct sk_buff *skb)
>                                 return err;
>                         break;
>
> +               case OVS_ACTION_ATTR_SET_MASKED:
> +                       err = masked_set_action_to_attr(a, skb);
> +                       if (err)
> +                               return err;
> +                       break;

I don't think this is necessary - the default case will handle things
that don't need any special processing.

I think you can also remove the port checks in validate_tp_port()
since the reasoning behind them is the same as the IP proto check.

Otherwise, I'm generally happy with this though.



More information about the dev mailing list