[ovs-dev] [PATCH/RFC 3/9] Support translation of NMX selection method

Ben Pfaff blp at nicira.com
Thu Dec 11 17:46:19 UTC 2014


On Thu, Dec 11, 2014 at 09:44:57AM -0800, Ben Pfaff wrote:
> On Wed, Nov 19, 2014 at 09:44:57AM +0900, Simon Horman wrote:
> > Only the default existing behaviour is translated.
> > All other methods are rejected for now.
> > 
> > NMX selection method
> > Signed-off-by: Simon Horman <simon.horman at netronome.com>
> 
> I understand why a string is the wire format for the selection method.
> I wonder, however, whether the wire format should be translated to some
> internal representation (such as an enum) at the time we parse the
> action into an ofpact.  

Excuse me, I mean, when the group_mod creates the group.

> It seems like there'd be an advantage to rejecting unsupported methods
> earlier, at the time the group is created, rather than each time we
> try to use the group.
> 
> Thoughts?
> 
> Thanks,
> 
> Ben.



More information about the dev mailing list