[ovs-dev] [PATCH 1/2] datapath: compat: introduce ovs_iptunnel_handle_offloads()

[Jesse Gross]

On Mon, Dec 22, 2014 at 1:06 PM, Pravin Shelar <pshelar at nicira.com> wrote:
> On Sun, Dec 21, 2014 at 2:56 PM, Jesse Gross <jesse at nicira.com> wrote:
>> On Fri, Dec 19, 2014 at 7:24 PM, Pravin B Shelar <pshelar at nicira.com> wrote:
>>> diff --git a/datapath/linux/compat/ip_tunnels_core.c b/datapath/linux/compat/ip_tunnels_core.c
>>> index e71ba4e..7606ad6 100644
>>> --- a/datapath/linux/compat/ip_tunnels_core.c
>>> +++ b/datapath/linux/compat/ip_tunnels_core.c
>>> +struct sk_buff *ovs_iptunnel_handle_offloads(struct sk_buff *skb,
>>> +                                             bool csum_help,
>>> +                                            void (*fix_segment)(struct sk_buff *))
>>> +{
>>> +       int err;
>>> +
>>> +       if (skb_is_encapsulated(skb)) {
>>> +               err = -ENOSYS;
>>> +               goto error;
>>> +       }
>>> +
>>> +       /* XXX: synchronize inner header for compat and non compat code so that
>>> +        * we can do it here.
>>> +        */
>>> +
>>> +       /* skb_reset_inner_headers(skb); */
>>
>> What is the issue with resetting the inner headers here?
>>
> I wrote above comment, I guess it is not very clear.
>
> Problem is current code does not set inner-header in handle offload
> call, some times handle_offload() is called after pushing outer
> header. I am planning on sending another patch to fix this issue.

OK, I see.