[ovs-dev] [PATCH] openvswitch: fix odd_ptr_err.cocci warnings

Pravin Shelar pshelar at nicira.com
Wed Dec 24 18:49:22 UTC 2014


On Tue, Dec 23, 2014 at 10:41 PM, kbuild test robot
<fengguang.wu at intel.com> wrote:
> net/openvswitch/vport-gre.c:188:5-11: inconsistent IS_ERR and PTR_ERR, PTR_ERR on line 189
>
>  PTR_ERR should access the value just tested by IS_ERR
>
> Semantic patch information:
>  There can be false positives in the patch case, where it is the call
>  IS_ERR that is wrong.
>
> Generated by: scripts/coccinelle/tests/odd_ptr_err.cocci
>
> CC: Pravin B Shelar <pshelar at nicira.com>
> Signed-off-by: Fengguang Wu <fengguang.wu at intel.com>

Thanks for the fix.

Acked-by: Pravin B Shelar <pshelar at nicira.com>

> ---
>
>  vport-gre.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- a/net/openvswitch/vport-gre.c
> +++ b/net/openvswitch/vport-gre.c
> @@ -186,7 +186,7 @@ static int gre_tnl_send(struct vport *vp
>         /* Push Tunnel header. */
>         skb = __build_header(skb, tunnel_hlen);
>         if (IS_ERR(skb)) {
> -               err = PTR_ERR(rt);
> +               err = PTR_ERR(skb);
>                 skb = NULL;
>                 goto err_free_rt;
>         }



More information about the dev mailing list