[ovs-dev] [PATCH] Warn the free of 'recirc_id' by wrong 'ofproto'.

[Alex Wang]

On Mon, Dec 29, 2014 at 12:47 PM, Ben Pfaff <blp at nicira.com> wrote:

> On Tue, Dec 23, 2014 at 02:21:06PM -0800, Alex Wang wrote:
> > Issues a ERR log when the 'recirc_id' is not freed by the
> > owning 'ofproto'.
> >
> > Signed-off-by: Alex Wang <alexw at nicira.com>
>
> How did this come up?  (Should this be an assertion?)
>

Hey Ben,

Since ofprotos of each datapath share one recirc_id pool, here the ofproto
is just used to dereference the 'backer'.  And that's why it is
theoretically
possible to pass in non-owning ofproto as argument. So far, there is no such
use.

I think we should use an assert here with proper comments.  Will send out a
patch soon,

Thanks,
Alex Wang,