[ovs-dev] [per-pmd ftb/cls V2 3/3] dpif-netdev: Add per-pmd flow-table/classifier.

[Alex Wang]

Thx for the review, did a final round of testing,

Applied to master~

On Mon, Dec 29, 2014 at 11:21 AM, Pravin Shelar <pshelar at nicira.com> wrote:

> On Sat, Dec 20, 2014 at 12:35 AM, Alex Wang <alexw at nicira.com> wrote:
> > This commit changes the per dpif-netdev datapath flow-table/
> > classifier to per pmd-thread.  As direct benefit, datapath
> > and flow statistics no longer need to be protected by mutex
> > or be declared as per-thread variable, since they are only
> > written by the owning pmd thread.
> >
> > As side effects, the flow-dump output of userspace datapath
> > can contain overlapping flows.  To reduce confusion, the dump
> > from different pmd thread will be separated by a title line.
> > In addition, the flow operations via 'ovs-appctl dpctl/*'
> > are modified so that if the given flow in_port corresponds
> > to a dpdk interface, the operation will be conducted to all
> > pmd threads recv from that interface.
> >
> > Signed-off-by: Alex Wang <alexw at nicira.com>
> >
> > ---
> > PATCH->V2:
> > - replace 'poller_id' with 'pmd_id'.
> > - remove unnecessary 'ovs_numa_core_id_is_valid()' check in
> >   dpif_netdev_flow_*().
> > - inline clear_stats().
> > - ovsrcu_postpone the destroy of 'pmd' for thread-safety.
> > - rebase to master.
>
> Thanks for all fixes.
>
> LGTM
> Acked-by: Pravin B Shelar <pshelar at nicira.com>
>