[ovs-dev] [GIT net] Open vSwitch

Jesse Gross jesse at nicira.com
Thu Feb 6 07:32:19 UTC 2014


On Wed, Feb 5, 2014 at 11:09 PM, Or Gerlitz <or.gerlitz at gmail.com> wrote:
> On Wed, Feb 5, 2014 at 8:59 AM, Jesse Gross <jesse at nicira.com> wrote:
>>
>> A handful of bug fixes for net/3.14. High level fixes are:
>>  * Regressions introduced by the zerocopy changes, particularly with
>>    old userspaces.
>
> Hi, so this post was the 2nd version of the five patches you posted
> earlier, right? it would be very helpful if you
> denote that on the subject line (e.g just use --subject-prefix="PATCH
> net V1" for git format-patch) and provide
> crash diff listing from V0. Also, on a related note to the patch that
> deals with locking, I see these two smatch
> complaints, which might be false-positives, what's your thinking?
>
> net/openvswitch/flow.c:127 ovs_flow_stats_get() warn: returning with
> unbalanced local_bh_disable
> net/openvswitch/flow.c:160 ovs_flow_stats_clear() warn: returning with
> unbalanced local_bh_disable

Yes, it looks like a false positive to me.



More information about the dev mailing list