[ovs-dev] [PATCH] Always insert MPLS labels after VLAN tags.

Ben Pfaff blp at nicira.com
Fri Feb 7 01:20:02 UTC 2014


On Wed, Feb 05, 2014 at 09:45:03AM +0900, Simon Horman wrote:
> On Tue, Feb 04, 2014 at 12:39:37PM -0800, Ben Pfaff wrote:
> > OpenFlow 1.1 and 1.2 always inserted MPLS labels after VLAN tags.
> > OpenFlow 1.3 and 1.4 insert MPLS labels before VLAN tags.
> > OpenFlow 1.3.4 and 1.5, both in preparation, recognize that the change in
> > 1.3 was an error and revert it.  This commit implements that reversion
> > in Open vSwitch.
> > 
> > EXT-457.
> > Signed-off-by: Ben Pfaff <blp at nicira.com>
> 
> Thanks Ben,
> 
> I wasn't aware of this revision and it certainly simplifies things a lot.
> I have run this through some tests that I have been carrying locally
> that exercise VLAN and MPLS combinations and I am happy to say that it
> passes. I will post them shortly as "MPLS + VLAN tests".
> 
> In the mean time
> 
> Acked-by: Simon Horman <horms at verge.net.au>

Applied, thanks for the review.



More information about the dev mailing list