[ovs-dev] [PATCH] bond: Change the way of assigning bond slave for unassigned bond entry.

Ben Pfaff blp at nicira.com
Fri Feb 7 18:09:30 UTC 2014


On Thu, Feb 06, 2014 at 04:31:27PM -0800, Alex Wang wrote:
> Before this commit, ovs randomly selects a slave for unassigned
> bond entry.  If the selected slave is not enabled, the active slave
> is chosen instead.  In this commit, the slave is selected from the
> list of all enabled slaves in a round-robin fashion.  This helps
> improve the consistency of bond behavior when new flows are added.
> 
> Signed-off-by: Alex Wang <alexw at nicira.com>

In get_enabled_slave(), I think that the test for an empty list needs to
take place while holding the lock.  Otherwise it could see an
intermediate version of the list while another thread is rotating it.



More information about the dev mailing list