[ovs-dev] [PATCH 3/4] tests: Fix MPLS test cases.

[Joe Stringer]

On 11 February 2014 10:01, Ben Pfaff <blp at nicira.com> wrote:

> On Fri, Feb 07, 2014 at 04:39:54PM -0800, Joe Stringer wrote:
> > The "userspace" MPLS test case was checking the same things as the
> > "drop" test case, rather than checking to see that packets were being
> > sent to userspace. This patch makes the testsuite consistent with itself.
> >
> > Signed-off-by: Joe Stringer <joestringer at nicira.com>
> > ---
> > I'm not sure what the intended behaviour is here. At the moment we seem
> > to send packets with <= 3 LSEs to userspace, and drop packets with > 4
> > LSEs. If that's intended, this patch matches that. If not, we should
> > probably change the behaviour and these tests.
>
> That's the expected behavior for the moment, although I would only
> expect packets to get dropped with >4 LSEs if one attempts to push or
> pop an MPLS header.
>

Ah, that's what I meant. This testcase doesn't distinguish between the two.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openvswitch.org/pipermail/ovs-dev/attachments/20140211/efb931f0/attachment-0003.html>