[ovs-dev] [PATCH 3/7] ofproto: Optimize the case of a repeated learn action execution.

Ben Pfaff blp at nicira.com
Wed Feb 12 00:54:09 UTC 2014

On Tue, Feb 11, 2014 at 04:30:45PM -0800, Jarno Rajahalme wrote:
> When the target flow exists already as intended, only the 'modified'
> time needs to be updated.  Allow modification without taking the
> 'ofproto_mutex' by always using the 'rule->mutex' when accessing the
> 'modified' time.
> Signed-off-by: Jarno Rajahalme <jrajahalme at nicira.com>

This is a good idea.  Thank you.

In ofproto_flow_mod(), the check 
                && !(fm->flags & OFPUTIL_FF_RESET_COUNTS)
can be moved to the top of the function, since it doesn't depend on what
we find in the rule (or whether we find a rule).

This adds a spurious blank line to ofopgroup_complete().

Acked-by: Ben Pfaff <blp at nicira.com>

More information about the dev mailing list