[ovs-dev] [PATCH] tests: Add support for automatically running Ryu tests against OVS.

Ben Pfaff blp at nicira.com
Fri Feb 14 18:43:14 UTC 2014


On Fri, Feb 14, 2014 at 06:14:02PM +0900, Simon Horman wrote:
> On Fri, Feb 07, 2014 at 11:23:57PM -0800, Ben Pfaff wrote:
> > On Fri, Feb 07, 2014 at 11:18:53PM -0800, Ben Pfaff wrote:
> > > The Ryu controller comes with an extensive library of OpenFlow tests, but
> > > it doesn't seem so easy to me to run all of them against a development
> > > version of Open vSwitch.  This commit introduces a Makefile target so that
> > > one can run all the Ryu tests with a simple "make check-ryu".
> > > 
> > > This commit adds documentation for the new target to INSTALL.  It also
> > > moves the documentation for the "check-oftest" target and the
> > > --enable-coverage configure option into INSTALL.
> > > 
> > > Signed-off-by: Ben Pfaff <blp at nicira.com>
> 
> Thanks for this, it looks good to me.
> 
> Reviewed-by: Simon Horman <horms at verge.net.au>

Applied to master, thanks.

> > By the way, I've run these tests several times as part of developing
> > this makefile target.  Open vSwitch doesn't pass all of the tests that I
> > would expect, so I imagine it's worthwhile to look over the test results
> > and spend some time finding and fixing OVS bugs.  I don't know whether
> > I'll have time to do that myself.
> 
> I have begun looking through these. If there is any area you would
> like me to focus on please let me know.

I did not look at them in enough detail for that.

I guess that the summary of results on the Ryu website is easier to
read, but "make check-ryu" is good for verifying that any changes one
makes will fix the problem in Ryu's opinion.



More information about the dev mailing list