[ovs-dev] [PATCH v7] datapath: Per NUMA node flow stats.
jrajahalme at nicira.com
Tue Feb 18 18:14:50 UTC 2014
Thanks for the reviews. I fixed the comments and the sparse warning and pushed to master.
On Feb 16, 2014, at 12:05 AM, Jesse Gross <jesse at nicira.com> wrote:
> On Fri, Feb 14, 2014 at 4:15 PM, Pravin Shelar <pshelar at nicira.com> wrote:
>> I got following sparse warning.
>> /home/pravin/ovs/w6/datapath/linux/flow_table.c:97:9: warning:
>> incorrect type in argument 1 (different address spaces)
>> /home/pravin/ovs/w6/datapath/linux/flow_table.c:97:9: expected
>> struct spinlock [usertype] *lock
>> /home/pravin/ovs/w6/datapath/linux/flow_table.c:97:9: got struct
>> spinlock [noderef] <asn:4>*<noident>
>> Otherwise looks good.
> One other thing - can you make multiline comments be of the form:
> /* ds
> * sfd
> People sometimes complain about this. Otherwise it looks good to me as well.
> Acked-by: Jesse Gross <jesse at nicira.com>
More information about the dev