[ovs-dev] [PATCH] ofp-actions: Correct pop MPLS ethtype as consistency test

Ben Pfaff blp at nicira.com
Wed Feb 19 21:37:50 UTC 2014


On Wed, Feb 19, 2014 at 09:27:16PM +0900, Simon Horman wrote:
> Correct pop MPLS ethtype consistency check to verify that
> the packet has an MPLS ethtype before the pop action rather than after:
> an MPLS ethtype is a pre-condition but not a post-condition of pop MPLS.
> 
> With this change the consistency check in ofpact_check__()
> becomes consistent with that in ofpact_from_nxast().
> 
> This was found using Ryu tests via the new make check-ryu target.
> It allows all of the "POP_MPLS"[1] tests to pass where they previously
> failed.
> 
> [1] http://osrg.github.io/ryu-certification/switch/ovs
> 
> Cc: Jarno Rajahalme <jrajahalme at nicira.com>
> Signed-off-by: Simon Horman <horms at verge.net.au>

The check-ryu target has already paid off, then.

Applied, thanks!



More information about the dev mailing list