[ovs-dev] [PATCH v2 2/2] process: Make changes for Windows.

Ben Pfaff blp at nicira.com
Wed Feb 19 22:16:41 UTC 2014


On Wed, Feb 19, 2014 at 02:02:33PM -0800, Gurucharan Shetty wrote:
> On Wed, Feb 19, 2014 at 1:08 PM, Ben Pfaff <blp at nicira.com> wrote:
> > On Fri, Feb 14, 2014 at 03:15:48PM -0800, Gurucharan Shetty wrote:
> >> As of now, we are using the process subsystem in
> >> ovsdb-server to handle the "--run" command line
> >> option. That particular option is not used often
> >> and till deemed necessary, make it unsupported on
> >> Windows platform.
> >>
> >> Signed-off-by: Gurucharan Shetty <gshetty at nicira.com>
> >
> > This makes process_status_msg() return a null pointer instead of a
> > string.  That could cause problems for the caller (e.g. segfault).  I
> > think it would be better to return a malloc()'d string for
> > consistency.  (Probably doesn't matter but just in case.)
> Okay.
> >
> > process_wait() could be implemented as OVS_NOT_REACHED() since after
> > all it shouldn't be possible to get a valid "struct process *" on
> > Windows.
> Okay.
> >
> > Acked-by: Ben Pfaff <blp at nicira.com>
> 
> Thanks. I will add the following incremental and push it in a couple
> of hours.

OK, thanks.



More information about the dev mailing list