[ovs-dev] openvswitch-2.0.0 : ovs-vswitchd segfault in netdev_get_etheraddr

Sridhar Samudrala samudrala.sridhar at gmail.com
Fri Feb 21 17:37:10 UTC 2014


On 2/21/2014 8:38 AM, Ben Pfaff wrote:
> On Thu, Feb 20, 2014 at 11:06:07PM -0800, Sridhar Samudrala wrote:
>> I am seeing a segfault with ovs-vswitchd when a VM attached to a OVS
>> bridge is shutdown.
>> I am running openvswitch-2.0.0 on linux kernel:3.10.30
>>
>> Is this a known issue with any fix in the git repository?
> Can you reproduce the problem?
Yes.  It happens everytime the VM is shutdown and STP is enabled on the 
bridge.
>   Can you try this fix?
I had to change ofport->stp_port to port->stp_port to fix the compile error.
With that change, the following patch fixes the segfault.

Thanks
Sridhar
>
> diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-dpif.c
> index 328b215..35a9556 100644
> --- a/ofproto/ofproto-dpif.c
> +++ b/ofproto/ofproto-dpif.c
> @@ -1550,6 +1550,9 @@ port_destruct(struct ofport *port_)
>       bundle_remove(port_);
>       set_cfm(port_, NULL);
>       set_bfd(port_, NULL);
> +    if (ofport->stp_port) {
> +        stp_port_disable(ofport->stp_port);
> +    }
>       if (ofproto->sflow) {
>           dpif_sflow_del_port(ofproto->sflow, port->odp_port);
>       }
>
> Thanks,
>
> Ben.




More information about the dev mailing list