[ovs-dev] [PATCH 06/14] socket-util: poll() for Windows.

Gurucharan Shetty shettyg at nicira.com
Fri Feb 21 19:38:19 UTC 2014


On Thu, Feb 20, 2014 at 5:14 PM, Ben Pfaff <blp at nicira.com> wrote:
> On Wed, Feb 19, 2014 at 03:36:17PM -0800, Gurucharan Shetty wrote:
>> Windows send() does not have a MSG_DONTWAIT.
>> So, use the get_socket_error() function.
>>
>> Co-authored-by: Linda Sun <lsun at vmware.com>
>> Signed-off-by: Linda Sun <lsun at vmware.com>
>> Signed-off-by: Gurucharan Shetty <gshetty at nicira.com>
>
> The use of MSG_DONTWAIT here is just caution, since it only makes sense
> to use check_connection_completion() on a nonblocking socket anyhow.  So
> I would prefer to just change MSG_DONTWAIT to 0 here.
Okay. Though I do not understand why we are ignoring POLLHUP for pfd.revents.



More information about the dev mailing list