[ovs-dev] [PATCH v2 3/4] socket-util: poll() for Windows.

Gurucharan Shetty shettyg at nicira.com
Fri Feb 21 21:49:03 UTC 2014


On Fri, Feb 21, 2014 at 1:39 PM, Ben Pfaff <blp at nicira.com> wrote:
> On Fri, Feb 21, 2014 at 01:14:35PM -0800, Gurucharan Shetty wrote:
>> +#ifndef _WIN32
>>      pfd.events = POLLOUT;
>> +#else
>> +    pfd.events = POLLWRNORM;
>> +#endif
>
> Does this mean that Windows has POLLWRNORM but not POLLOUT?  POSIX
> says they're equivalent, so we could either use POLLWRNORM everywhere
> or just #define POLLOUT POLLWRNORM in poll-loop.h.  I lean toward the
> latter, since POLLOUT is more "idiomatic" in my experience.
I see that winsock2.h has (The documentation did not mention it):
#define POLLOUT     (POLLWRNORM)

So, I will get rid of the #ifdef

>
> Otherwise,
> Acked-by: Ben Pfaff <blp at nicira.com>
Thanks.



More information about the dev mailing list