[ovs-dev] [PATCH 1/2] ovs-vswitchd: Don't register for SIGHUP.

[Gurucharan Shetty]

On Fri, Feb 21, 2014 at 1:44 PM, Ben Pfaff <blp at nicira.com> wrote:
> On Thu, Feb 20, 2014 at 03:17:15PM -0800, Gurucharan Shetty wrote:
>> We are registering an interest in SIGHUP to reopen
>> log files. But there is an 'ovs-appctl vlog/reopen'
>> command that does the same and is used in the
>> logrotate config for the distributions.
>>
>> So remove the redundant functionality.
>>
>> Signed-off-by: Gurucharan Shetty <gshetty at nicira.com>
>
> I'm a little worried that some third-party script might be using
> SIGHUP for this purpose, so please add an item to NEWS that mentions
> this change.
How about the following incremental?

diff --git a/NEWS b/NEWS
index 34dde6b..26d731f 100644
--- a/NEWS
+++ b/NEWS
@@ -4,6 +4,9 @@ Post-v2.1.0
      poorly maintained and not widely used.
    - New "check-ryu" Makefile target for running Ryu tests for OpenFlow
      controllers against Open vSwitch.  See INSTALL for details.
+   - Upon the receipt of a SIGHUP signal, ovs-vswitchd no longer reopens its
+     log file (it will terminate instead). Please use 'ovs-appctl vlog/reopen'
+     instead.

 v2.1.0 - xx xxx xxxx
 ---------------------


>
> Acked-by: Ben Pfaff <blp at nicira.com>
>
> Thanks,
>
> Ben.