[ovs-dev] [PATCH] meta-flow: Remove duplicate break statements.

Joe Stringer joestringer at nicira.com
Mon Feb 24 18:20:22 UTC 2014


Commit 8bfd0fda mistakenly introduced duplicate "break;" statements to
MFF_MPLS_BOS handling. This patch removes them.

Found by inspection.

Signed-off-by: Joe Stringer <joestringer at nicira.com>
---
 lib/meta-flow.c |    4 ----
 1 file changed, 4 deletions(-)

diff --git a/lib/meta-flow.c b/lib/meta-flow.c
index 3afcd4c..d90477a 100644
--- a/lib/meta-flow.c
+++ b/lib/meta-flow.c
@@ -1298,7 +1298,6 @@ mf_get_value(const struct mf_field *mf, const struct flow *flow,
     case MFF_MPLS_BOS:
         value->u8 = mpls_lse_to_bos(flow->mpls_lse[0]);
         break;
-        break;
 
     case MFF_IPV4_SRC:
         value->be32 = flow->nw_src;
@@ -1495,7 +1494,6 @@ mf_set_value(const struct mf_field *mf,
     case MFF_MPLS_BOS:
         match_set_mpls_bos(match, 0, value->u8);
         break;
-        break;
 
     case MFF_IPV4_SRC:
         match_set_nw_src(match, value->be32);
@@ -1709,7 +1707,6 @@ mf_set_flow_value(const struct mf_field *mf,
     case MFF_MPLS_BOS:
         flow_set_mpls_bos(flow, 0, value->u8);
         break;
-        break;
 
     case MFF_IPV4_SRC:
         flow->nw_src = value->be32;
@@ -1920,7 +1917,6 @@ mf_set_wild(const struct mf_field *mf, struct match *match)
     case MFF_MPLS_BOS:
         match_set_any_mpls_bos(match, 0);
         break;
-        break;
 
     case MFF_IPV4_SRC:
     case MFF_ARP_SPA:
-- 
1.7.9.5




More information about the dev mailing list