[ovs-dev] [PATCH 5/5] upcall: Remove datapath flows when setting n-threads.

Zhou, Han hzhou8 at ebay.com
Tue Feb 25 08:01:17 UTC 2014


Hi Joe,

On Tue, 2014-02-11 at 13:55 -0800, Joe Stringer wrote:
> Previously, we would delete all ukeys when changing the number of
> threads, but leave all flows in the datapath. This would cause
> double-counting of stats for any flows that remain in the datapath. This
> patch fixes the issue by ensuring that all flows are deleted from the
> datapath before changing the number of threads.
> 

Would this change impact data traffic when thread number is being
changed? I am afraid there will be a burst of upcalls when datapath
flows are deleted, while the handlers are already destroyed and packet
drops could increase significantly. Would it be better if we delete
flows after new handler threads are created?

Best regards,
Han Zhou



More information about the dev mailing list