[ovs-dev] [PATCH] Windows implementation of stream-fd.

Linda Sun lsun at vmware.com
Tue Feb 25 17:45:58 UTC 2014


Sounds good to me. 

Linda



> On Feb 24, 2014, at 8:34 PM, Gurucharan Shetty <shettyg at nicira.com> wrote:
> 
>> On Wed, Feb 12, 2014 at 1:50 PM, Linda Sun <lsun at vmware.com> wrote:
>> Use send/recv for socket stream instead of read/write.
>> Use event handle for polling on socket stream.
>> Check windows specific return code.
>> 
>> Signed-off-by: Linda Sun <lsun at vmware.com>
> 
> I think we need to use the following .gitconfig setting:
> [diff]
>   renames = copies
> 
> With the above setting, renames won't show as absolute new additions
> making it easier to review.
> 
> I had to make some changes to handle the change in structures in
> lib/stream-tcp.c. I also had to make some changes to handle the change
> in poll_block() implementation which converts POLLIN/POLLOUT to FD_*
> events.
> 
> I sent out the change. What do you think? If you are fine with it, I will apply



More information about the dev mailing list