[ovs-dev] [PATCH 5/5] upcall: Remove datapath flows when setting n-threads.

Ben Pfaff blp at nicira.com
Wed Feb 26 00:31:27 UTC 2014


On Tue, Feb 25, 2014 at 04:18:38PM -0800, Ben Pfaff wrote:
> On Tue, Feb 25, 2014 at 04:17:12PM -0800, Joe Stringer wrote:
> > On 25 February 2014 16:02, Ben Pfaff <blp at nicira.com> wrote:
> > 
> > > On Tue, Feb 11, 2014 at 01:55:36PM -0800, Joe Stringer wrote:
> > > > Previously, we would delete all ukeys when changing the number of
> > > > threads, but leave all flows in the datapath. This would cause
> > > > double-counting of stats for any flows that remain in the datapath. This
> > > > patch fixes the issue by ensuring that all flows are deleted from the
> > > > datapath before changing the number of threads.
> > > >
> > > > Signed-off-by: Joe Stringer <joestringer at nicira.com>
> > >
> > > I applied this series to master.  I think it needs backports, too;
> > > I'll look at that.
> > >
> > 
> > Yes, I believe that these bugs are all present on branch-2.1.
> > 
> > I think there's also one more bug in this area, I'll send a patch.
> 
> I introduced a bug as part of my changes.  I'll send a fix.

I sent out two fixes.  The first is important, please look at it right
away.



More information about the dev mailing list