[ovs-dev] [PATCH] meta-flow: Remove duplicate break statements.
Jarno Rajahalme
jrajahalme at nicira.com
Wed Feb 26 00:47:53 UTC 2014
Yep, will do :-)
Jarno
> On Feb 24, 2014, at 10:44 AM, Ben Pfaff <blp at nicira.com> wrote:
>
> You want to push it for Joe?
>
>> On Mon, Feb 24, 2014 at 10:37:04AM -0800, Jarno Rajahalme wrote:
>> Acked-by: Jarno Rajahalme <jrajahalme at nicira.com>
>>
>>> On Feb 24, 2014, at 10:20 AM, Joe Stringer <joestringer at nicira.com> wrote:
>>>
>>> Commit 8bfd0fda mistakenly introduced duplicate "break;" statements to
>>> MFF_MPLS_BOS handling. This patch removes them.
>>>
>>> Found by inspection.
>>>
>>> Signed-off-by: Joe Stringer <joestringer at nicira.com>
>>> ---
>>> lib/meta-flow.c | 4 ----
>>> 1 file changed, 4 deletions(-)
>>>
>>> diff --git a/lib/meta-flow.c b/lib/meta-flow.c
>>> index 3afcd4c..d90477a 100644
>>> --- a/lib/meta-flow.c
>>> +++ b/lib/meta-flow.c
>>> @@ -1298,7 +1298,6 @@ mf_get_value(const struct mf_field *mf, const struct flow *flow,
>>> case MFF_MPLS_BOS:
>>> value->u8 = mpls_lse_to_bos(flow->mpls_lse[0]);
>>> break;
>>> - break;
>>>
>>> case MFF_IPV4_SRC:
>>> value->be32 = flow->nw_src;
>>> @@ -1495,7 +1494,6 @@ mf_set_value(const struct mf_field *mf,
>>> case MFF_MPLS_BOS:
>>> match_set_mpls_bos(match, 0, value->u8);
>>> break;
>>> - break;
>>>
>>> case MFF_IPV4_SRC:
>>> match_set_nw_src(match, value->be32);
>>> @@ -1709,7 +1707,6 @@ mf_set_flow_value(const struct mf_field *mf,
>>> case MFF_MPLS_BOS:
>>> flow_set_mpls_bos(flow, 0, value->u8);
>>> break;
>>> - break;
>>>
>>> case MFF_IPV4_SRC:
>>> flow->nw_src = value->be32;
>>> @@ -1920,7 +1917,6 @@ mf_set_wild(const struct mf_field *mf, struct match *match)
>>> case MFF_MPLS_BOS:
>>> match_set_any_mpls_bos(match, 0);
>>> break;
>>> - break;
>>>
>>> case MFF_IPV4_SRC:
>>> case MFF_ARP_SPA:
>>> --
>>> 1.7.9.5
>>>
>>> _______________________________________________
>>> dev mailing list
>>> dev at openvswitch.org
>>> http://openvswitch.org/mailman/listinfo/dev
>>
>> _______________________________________________
>> dev mailing list
>> dev at openvswitch.org
>> http://openvswitch.org/mailman/listinfo/dev
More information about the dev
mailing list