[ovs-dev] [PATCH] ovs-lib: don't log service status operation

Flavio Leitner fbl at redhat.com
Thu Feb 27 11:56:48 UTC 2014


On Wed, Feb 26, 2014 at 08:33:22PM -0800, Gurucharan Shetty wrote:
> On Wed, Feb 26, 2014 at 8:28 PM, Ben Pfaff <blp at nicira.com> wrote:
> > On Wed, Feb 26, 2014 at 11:19:15PM -0300, Flavio Leitner wrote:
> >> It prevents non-root users to check service status.
> >>
> >> Signed-off-by: Flavio Leitner <fbl at redhat.com>
> >
> > Guru, if you're OK with this change, it's fine by me.  Otherwise, if
> > it's important to log, then we could compromise by using "tee" only if
> > "test -w" succeeds on ovs-ctl.log.
> Using "test -w" looks like a good idea. Flavio, what do you think?
> (I have found ovs-ctl.log contents useful for quite a few upgrade related bugs.)
>

I see no problems.  I will send a v2.
thanks!



More information about the dev mailing list