[ovs-dev] [PATCH] ovs-lib: allow non-root users to check service status

Gurucharan Shetty shettyg at nicira.com
Thu Feb 27 15:42:44 UTC 2014


On Thu, Feb 27, 2014 at 4:16 AM, Flavio Leitner <fbl at redhat.com> wrote:
> It tries to log the status operation, so although non-root
> users can see the current status, the lack of permission
> to write to the log results in an error message.
>
> This changes to log only if the user has the permission to
> write to the log file.
>
> Signed-off-by: Flavio Leitner <fbl at redhat.com>
Thanks. Applied to master.
> ---
>  utilities/ovs-lib.in | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/utilities/ovs-lib.in b/utilities/ovs-lib.in
> index 029ed3b..48d0c36 100644
> --- a/utilities/ovs-lib.in
> +++ b/utilities/ovs-lib.in
> @@ -54,7 +54,11 @@ ovs_ctl () {
>              # of ovs-ctl. It is also useful to document the o/p in ovs-ctl.log.
>              display=`"${datadir}/scripts/ovs-ctl" "$@" 2>&1`
>              rc=$?
> -            echo "${display}" | tee -a "${logdir}/ovs-ctl.log"
> +            if test -w "${logdir}/ovs-ctl.log"; then
> +                 echo "${display}" | tee -a "${logdir}/ovs-ctl.log"
> +            else
> +                 echo "${display}"
> +            fi
>              return ${rc}
>          ;;
>          *)
> --
> 1.8.5.3
>



More information about the dev mailing list