[ovs-dev] [PATCH v3 3/3] ofproto: Honour Table Mod settings for table-miss handling

Ben Pfaff blp at nicira.com
Mon Jan 6 06:47:14 UTC 2014


Thanks. I'm back from vacation Tuesday and hope to review the new version
this week.
On Jan 5, 2014 8:26 PM, "Simon Horman" <horms at verge.net.au> wrote:

> On Mon, Dec 30, 2013 at 01:57:37PM -0800, Ben Pfaff wrote:
> > On Mon, Dec 16, 2013 at 05:53:23PM +0900, Simon Horman wrote:
> > > This reworks lookup of rules for both table 0 and table action
> translation.
> > > The result is that Table Mod settings, which can alter the
> miss-behaviour
> > > of tables, including table 0, on a per-table basis may be honoured.
> > >
> > > Previous patches proposed by myself which build on earlier merged
> patches
> > > by Andy Zhou implement the ofproto side of Table Mod. So with this
> patch
> > > the feature should be complete.
> > >
> > > Neither this patch, nor any other patches it builds on, alter the
> default
> > > behaviour of Open vSwitch. And in particular the OpenFlow1.1 behaviour
> is
> > > the default regardless of which OpenFlow version is negotiated between
> the
> > > switch and the controller.
> > >
> > > An implementation detail, which lends itself to future work, is the
> > > handling of OFPTC_TABLE_MISS_CONTINUE. If a table has this behaviour
> set by
> > > Table Mod and a miss occurs then a loop is created, skipping to the
> next
> > > table. It is quite easy to create a situation where this loop covers
> ~255
> > > tables which is very expensive as the lookup for each table involves
> taking
> > > locks, amongst other things.
> > >
> > > Cc: Andy Zhou <azhou at nicira.com>
> > > Signed-off-by: Simon Horman <horms at verge.net.au>
> >
> > I guess that this needs a rebase now.  I hope to apply the new
> > revision.
>
> Thanks, I have sent v4 after rebasing.
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openvswitch.org/pipermail/ovs-dev/attachments/20140105/0b48515f/attachment-0003.html>


More information about the dev mailing list