[ovs-dev] [PATCH v2 1/3] userspace: add support for pop_eth and push_eth actions

[Jesse Gross]

On Mon, Jan 6, 2014 at 2:14 PM, Lori Jakab <lojakab at cisco.com> wrote:
> On 1/6/14 6:30 PM, Jesse Gross wrote:
>>
>> On Tue, Dec 24, 2013 at 9:02 AM, Lorand Jakab <lojakab at cisco.com> wrote:
>>>
>>> diff --git a/include/linux/openvswitch.h b/include/linux/openvswitch.h
>>> index 5137c2f..46b3634 100644
>>> --- a/include/linux/openvswitch.h
>>> +++ b/include/linux/openvswitch.h
>>>    * @OVS_ACTION_ATTR_OUTPUT: Output packet to port.
>>> @@ -569,6 +579,8 @@ enum ovs_action_attr {
>>>          OVS_ACTION_ATTR_SAMPLE,       /* Nested OVS_SAMPLE_ATTR_*. */
>>>          OVS_ACTION_ATTR_PUSH_MPLS,    /* struct ovs_action_push_mpls. */
>>>          OVS_ACTION_ATTR_POP_MPLS,     /* __be16 ethertype. */
>>> +       OVS_ACTION_ATTR_PUSH_ETH,     /* struct ovs_action_push_eth. */
>>> +       OVS_ACTION_ATTR_POP_ETH,      /* No argument. */
>>>          __OVS_ACTION_ATTR_MAX
>>>   };
>>
>> Given that there is no kernel code for MPLS currently checked in, we
>> should temporarily move those attributes to a high value and make the
>> push/pop Ethernet actions be the next in the list after SAMPLE
>> (similar to the MPLS match).
>
>
> Thanks for reviewing!
>
> Should I just switch positions, or should I explicitly set the MPLS actions
> to high values, something like:

I would explicitly give them high values. It's what should have been
done originally; the MPLS kernel patch can set it to the final IDs.