[ovs-dev] [mpls v2 1/2] Implement OpenFlow support for MPLS, for up to 3 labels.

Simon Horman horms at verge.net.au
Thu Jan 9 05:19:01 UTC 2014


On Wed, Jan 08, 2014 at 02:36:03PM -0500, Jesse Gross wrote:
> On Tue, Jan 7, 2014 at 11:03 PM, Simon Horman <horms at verge.net.au> wrote:
> > On Tue, Jan 07, 2014 at 09:30:54PM -0500, Jesse Gross wrote:
> >> I was talking about the case where there is a single pass and you have
> >> multiple MPLS pop actions. This previously wasn't possible because
> >> userspace only supported a single layer of MPLS and therefore couldn't
> >> issue such actions. However, with this patch it could potentially do
> >> that and the action validator that you wrote would reject the flow
> >> because there is no further checking of the underlying protocol.
> >
> > I guess a simple solution would be to defer such cases to recirculation.
> > That was, as I understand things, the plan before this patch came along.
> 
> I think at a minimum we probably need to think about any potential
> compatibility issues in the event that there is a mismatch in the
> number of labels are supported.

Ben, do you have any thoughts on this?

> Once we do that, it might actually be
> easier to just add support for a few more labels in the kernel - it
> wouldn't have any performance impact in the case where they aren't
> used and it certainly would be simpler than recirculation.

That sounds reasonable to me.



More information about the dev mailing list