[ovs-dev] [PATCH 1/2] netdev-linux: Use unsigned int for ifi_flags

Helmut Schaa helmut.schaa at googlemail.com
Thu Jan 9 07:51:53 UTC 2014


On Thu, Jan 9, 2014 at 1:09 AM, Ben Pfaff <blp at nicira.com> wrote:
> On Wed, Jan 08, 2014 at 04:43:46PM +0100, Helmut Schaa wrote:
>> ifi_flags is unsigned, the local equivalents should do the same.
>>
>> Signed-off-by: Helmut Schaa <helmut.schaa at googlemail.com>
>
> In the GNU C library, ifru_flags in struct ifreq, in net/if.h, has
> type short int.  I see that netdev-linux.c uses 'int' and 'unsigned
> int' variously.  I guess that the right change, if any is really
> needed, would be to use short int consistently.  Do you want to make
> that change?

Since I'll respin the other patch let's just drop this one for now ...
Helmut



More information about the dev mailing list