[ovs-dev] [PATCH 07/10] dpif: Don't fetch actions in dpif_flow_dump_next().

Ethan Jackson ethan at nicira.com
Mon Jan 13 23:20:01 UTC 2014


> My reading is that the desirable side effect here is that it gets rid
> of internal state in dumper implementations that would otherwise have
> to become per-thread state in upcoming patches.  It still makes
> getting the actions slow for everyone, but that's justifiable on the
> grounds that it doesn't matter to any existing users.

Right, the only existing user that matters from a performance
perspective is the flow dumper.  In that case, it only grabs the
actions in the case where we actually need them to do a revalidation.
If we're just pushing stats, we don't need to look at them.  That way
we save a system call in the common case.

Ethan

>
> Is that right?
>
> Thanks,
>
> Ben.
> _______________________________________________
> dev mailing list
> dev at openvswitch.org
> http://openvswitch.org/mailman/listinfo/dev



More information about the dev mailing list