[ovs-dev] [PATCH 1/3] ofproto-dpif-upcall: Avoid unnecessarily installing datapath flows.
Ben Pfaff
blp at nicira.com
Tue Jan 14 00:00:51 UTC 2014
On Mon, Jan 13, 2014 at 12:58:06PM -0800, Ben Pfaff wrote:
> On Mon, Jan 13, 2014 at 12:53:18PM -0800, Ethan Jackson wrote:
> > > + * installed in the kernel already. */
> > > + if (may_put
> > > + && !miss->put
> > > + && (!miss->xout.slow
> > > + || upcall->dpif_upcall.type == DPIF_UC_MISS)) {
> >
> > My only question here is why not just say, we only install flows with
> > DPIF_UC_MISS, instead of making that check only for xout.slow?
>
> I think you're right, I'll delete the test on 'slow'.
I applied all of these to master and branch-2.1.
Ethan, I doubt that they matter for earlier versions. Do you think
that 1.11 and 2.0 need patches 2 and 3?
More information about the dev
mailing list