[ovs-dev] [PATCH 4/4] daemon-windows: Add users for windows services.

Ben Pfaff blp at nicira.com
Fri Jan 17 21:37:36 UTC 2014


On Fri, Jan 17, 2014 at 01:30:27PM -0800, Gurucharan Shetty wrote:
> On Fri, Jan 17, 2014 at 1:13 PM, Ben Pfaff <blp at nicira.com> wrote:
> > On Fri, Jan 17, 2014 at 12:26:23PM -0800, Gurucharan Shetty wrote:
> >> Start with ovs-vswitchd and ovsdb-server.
> >>
> >> Signed-off-by: Gurucharan Shetty <gshetty at nicira.com>
> >
> > Will poll_block() wake up if a service stop has been requested?
> > Ideally, it would.
> I did not think a lot about it. I suppose we have a time limit in ms
> after which we wake up every time correct? 

No.  In ovs-vswitchd, for example, if nothing is happening, and no
bridges are configured, then poll_block() can block indefinitely.  

> I haven't seen (during my tests) a negative consequence of a small
> delay in stopping the service after a request. If that is indeed a
> problem, I will investigate more.

I assume a small delay is OK, too, but I don't think that the delay
here is bounded.

> > Why does this change set_program_name__()?
> set_program_name__() is called twice in windows, if service is
> configured. The change is to prevent additional memory allocation.

OK, thanks.



More information about the dev mailing list