[ovs-dev] [PATCH 3.2] lib: Add ipv6 support for active and passive socket connections

[Ben Pfaff]

On Tue, Dec 31, 2013 at 01:08:26PM +0530, Arun Sharma wrote:
> Allows active/passive socket operations to use IPv6 network addresses,
> except in-band control which is not supported for IPv6.
> 
> tests: Added tests for socket connections over IPv6.
> Also added tests for NetFlow and sFlow using IPv6 sockets.
> manpages: Updated connection information for IPv6 socket communication.
> 
> Signed-off-by: Nandan Nivgune <nandan.nivgune at calsoftinc.com>
> Signed-off-by: Abhijit Bhopatkar <abhijit.bhopatkar at calsoftinc.com>
> Signed-off-by: Arun Sharma <arun.sharma at calsoftinc.com>

include/sparse/netinet/in.h
---------------------------

Please don't define s6_addr16 here, or use it elsewhere, because it is
not portable: POSIX does not specify it.

Please don't use __SOCKADDR_COMMON in the definition of sockaddr_in6,
because it is a glibc-ism that doesn't belong here.


lib/packets.h
-------------

Please don't use or define IP6_*, because IPv6 addresses formatted
this way are often not in the format that people expect.  Use
inet_ntop() instead.


lib/rconn.c
-----------

What is the reason for the change here?


lib/socket-util.c
-----------------

Why does this use getaddrinfo() instead of just inet_pton() for
parsing addresses?  At least, AI_NUMERICHOST must be used to avoid DNS
lookups.



Thanks,

Ben.