[ovs-dev] [PATCH] Add stream-fd implementation for windows. Need to use send/recv instead of write/read operations. Use the event handle for polling. check windows return errors.

[Ben Pfaff]

I'm OK with this generally.  It needs a few changes.

It needs a Signed-off-by.

The commit message is formatted all as one long line.  Please format
it as recommended in git-commit(1):

       Though not required, it's a good idea to begin the commit message with
       a single short (less than 50 character) line summarizing the change,
       followed by a blank line and then a more thorough description. Tools
       that turn commits into email, for example, use the first line on the
       Subject: line and the rest of the commit in the body.

(Our summary lines often extend as wide as 75 columns though.)

I think one point here is that on Windows stream-fd can only handle
sockets, whereas on unix any fd is acceptable.  That might be worth
mentioning in stream-fd.h.

I see funny indentation in pfd_accept().  It looks like you used a tab
instead of spaces on one line.

It needs a rebase due to changes in lib/automake.mk.

I think that we should rename lib/stream-fd.c to lib/stream-fd-unix.c
(and probably lib/latch.c to lib/latch-unix.c while we're at it).

Thanks,

Ben.