[ovs-dev] [PATCH] configure: Don't check for malloc hooks that we no longer use.

Justin Pettit jpettit at nicira.com
Tue Jul 22 23:25:12 UTC 2014


Acked-by: Justin Pettit <jpettit at nicira.com>



On Tue, Jul 22, 2014 at 4:21 PM, Ben Pfaff <blp at nicira.com> wrote:

> Commit 825da1c6d1c7 (leak-checker: Remove because it cannot be made
> thread-safe.) removed the only uses of these hooks but neglected to remove
> the test for them.
>
> Signed-off-by: Ben Pfaff <blp at nicira.com>
> ---
>  configure.ac      |    1 -
>  m4/openvswitch.m4 |   20 --------------------
>  2 files changed, 21 deletions(-)
>
> diff --git a/configure.ac b/configure.ac
> index ebe4ef9..971c7b3 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -75,7 +75,6 @@ OVS_CHECK_PKIDIR
>  OVS_CHECK_RUNDIR
>  OVS_CHECK_DBDIR
>  OVS_CHECK_BACKTRACE
> -OVS_CHECK_MALLOC_HOOKS
>  OVS_CHECK_VALGRIND
>  OVS_CHECK_SOCKET_LIBS
>  OVS_CHECK_XENSERVER_VERSION
> diff --git a/m4/openvswitch.m4 b/m4/openvswitch.m4
> index 1308d1c..26b8058 100644
> --- a/m4/openvswitch.m4
> +++ b/m4/openvswitch.m4
> @@ -192,26 +192,6 @@ AC_DEFUN([OVS_CHECK_BACKTRACE],
>                    [AC_DEFINE([HAVE_BACKTRACE], [1],
>                               [Define to 1 if you have backtrace(3).])])])
>
> -dnl Checks for __malloc_hook, etc., supported by glibc.
> -AC_DEFUN([OVS_CHECK_MALLOC_HOOKS],
> -  [AC_CACHE_CHECK(
> -    [whether libc supports hooks for malloc and related functions],
> -    [ovs_cv_malloc_hooks],
> -    [AC_COMPILE_IFELSE(
> -      [AC_LANG_PROGRAM(
> -         [#include <malloc.h>
> -         ],
> -         [(void) __malloc_hook;
> -          (void) __realloc_hook;
> -          (void) __free_hook;])],
> -      [ovs_cv_malloc_hooks=yes],
> -      [ovs_cv_malloc_hooks=no])])
> -   if test $ovs_cv_malloc_hooks = yes; then
> -     AC_DEFINE([HAVE_MALLOC_HOOKS], [1],
> -               [Define to 1 if you have __malloc_hook, __realloc_hook, and
> -                __free_hook in <malloc.h>.])
> -   fi])
> -
>  dnl Checks for valgrind/valgrind.h.
>  AC_DEFUN([OVS_CHECK_VALGRIND],
>    [AC_CHECK_HEADERS([valgrind/valgrind.h])])
> --
> 1.7.10.4
>
> _______________________________________________
> dev mailing list
> dev at openvswitch.org
> http://openvswitch.org/mailman/listinfo/dev
>



More information about the dev mailing list