[ovs-dev] [PATCH] datapath: Enable tunnel GSO features.

Ben Pfaff blp at nicira.com
Wed Jul 2 22:40:32 UTC 2014


On Wed, Jul 02, 2014 at 02:21:58PM -0700, Pravin B Shelar wrote:
> Following patch enables all available tunnel GSO features for OVS
> bridge device so that ovs can use hardware offloads available to
> underling device.
> 
> Signed-off-by: Pravin B Shelar <pshelar at nicira.com>
> ---
>  acinclude.m4                                       |  2 ++
>  .../linux/compat/include/linux/netdev_features.h   | 36 ++++++++++++++++++++++
>  datapath/linux/compat/include/net/gre.h            | 13 ++++++++
>  datapath/linux/compat/include/net/vxlan.h          | 19 ++++++++++++
>  datapath/vport-geneve.c                            |  5 +++
>  datapath/vport-internal_dev.c                      |  8 ++++-
>  datapath/vport-lisp.c                              |  5 +++
>  7 files changed, 87 insertions(+), 1 deletion(-)
> 
> diff --git a/acinclude.m4 b/acinclude.m4
> index aa9ffcd..3d6d49b 100644
> --- a/acinclude.m4
> +++ b/acinclude.m4
> @@ -281,6 +281,8 @@ AC_DEFUN([OVS_CHECK_LINUX_COMPAT], [
>    OVS_GREP_IFELSE([$KSRC/include/linux/netdevice.h], [can_checksum_protocol])
>    OVS_GREP_IFELSE([$KSRC/include/linux/netdevice.h], [netdev_features_t])
>    OVS_GREP_IFELSE([$KSRC/include/linux/netdevice.h], [pcpu_sw_netstats])
> +  OVS_GREP_IFELSE([$KSRC/include/linux/netdev_features.h], [NETIF_F_GSO_GRE])
> +  OVS_GREP_IFELSE([$KSRC/include/linux/netdev_features.h], [NETIF_F_GSO_UDP_TUNNEL])

Do these need to be checked at configure time?  i.e., can you just change
    #ifndef NETIF_F_GSO_GRE
    #define NETIF_F_GSO_GRE	0
    #endif
in datapath/linux/compat/include/linux/netdev_features.h to just read:
    #ifdef NETIF_F_GSO_GRE
    #define HAVE_NETIF_F_GSO_GRE
    #else
    #define NETIF_F_GSO_GRE	0
    #endif

or even use "#if NETIF_F_GSO_GRE != 0" instead of "#ifdef
HAVE_NETIF_F_GSO_GRE"?



More information about the dev mailing list