[ovs-dev] [RFC 1/3] revalidator: Don't delete missed dp flows immediately.

Joe Stringer joestringer at nicira.com
Wed Jul 2 23:30:19 UTC 2014


Thanks for the discussion. Given the time constraints, I will prepare a
fresh version for branch-2.3 first, then address the issues on master
separately.


On 3 July 2014 08:56, Ben Pfaff <blp at nicira.com> wrote:

> On Wed, Jul 02, 2014 at 08:14:13PM +1200, Joe Stringer wrote:
> > There is no guarantee that performing a flow_dump will return a complete
> > version of the datapath's flow table. Occasionally, a flow may be
> > completely missed even if it is present in the datapath (particularly if
> > the datapath decides to rehash its flow tables). Previously we would
> > delete such "missed flows" immediately. This patch gives those flows a
> > chance to be dumped, which should improve jitter/ latency for flows in
> > this corner case.
> >
> > Signed-off-by: Joe Stringer <joestringer at nicira.com>
>
> We need to figure out whether this is the best approach.  If it is,
> then my only comment is that it's not easy to guess what the value of
> "last_seen" means from its name (or the comment in the struct).  I
> think that something like "n_misses" would better express the meaning.
>



More information about the dev mailing list