[ovs-dev] [PATCH] Prepare ground for extensions to sFlow export

Neil McKee neil.mckee at inmon.com
Wed Jul 9 22:08:53 UTC 2014


OK,  I'll reply again when I have extended this forked-repo to export the
standard sFlow-LAG structure.

Neil

------
Neil McKee
InMon Corp.
http://www.inmon.com


On Mon, Jul 7, 2014 at 8:55 AM, Ben Pfaff <blp at nicira.com> wrote:

> I took a look at the patch.  It's not necessary to submit a
> pull-request.
>
> The change seems reasonable to me.  Will you submit a followup patch to
> make use of the new statistics?  I do not think it makes sense to apply
> this until they are used.
>
> On Fri, Jun 27, 2014 at 11:34:11AM -0700, Neil McKee wrote:
> > OK,  I forked openvwitch/ovs on github to create this repo:
> >
> > https://github.com/sflow/ovs
> >
> > and then pushed the patch in there (with "Signed-off-by" in the commit
> > comment).
> >
> >
> https://github.com/sflow/ovs/commit/7aff910325fa3a4a11d363f09e06f83c64209485
> >
> > Should I submit a pull-request?
> >
> > Regards,
> > Neil
> >
> >
> > ------
> > Neil McKee
> > InMon Corp.
> > http://www.inmon.com
> >
> >
> > On Mon, Jun 23, 2014 at 1:20 PM, Ben Pfaff <blp at nicira.com> wrote:
> >
> > > On Fri, Jun 13, 2014 at 12:01:50PM -0700, Neil McKee wrote:
> > > >  Standard LACP counters are added to the LACP module, and
> > > >  the sFlow library and test modules are extended to support the
> > > >  export of those LACP counters as well as tunnel and OpenFlow
> > > >  related structures. None of these structures are actually
> > > >  exported yet,  so this patch should have no discernible
> > > >  effect. Hence no changes to the unit tests.
> > > >
> > > > Signed-off-by: Neil McKee <neil.mckee at inmon.com>
> > >
> > > Hi Neil.  This patch is badly whitespace damaged.  Could you repost
> > > it?  (If you can't make that work, then it's also acceptable to push
> > > it to a publicly accessible Git repo and point to it.)
> > >
> > > Thanks,
> > >
> > > Ben.
> > >
>



More information about the dev mailing list