[ovs-dev] [PATCH] datapath/flow_netlink: Fix NDP flow mask validation

Thomas Graf tgraf at noironetworks.com
Fri Jul 11 09:12:14 UTC 2014


On 07/10/14 at 09:32am, Daniele Di Proietto wrote:
> This cannot set tp.src to htons(0xffff), because icmpv6_key->icmpv6_type is __u8.
> 
> The bug has always been there, since a1c564be (datapath: Mega flow implementation).
> 
> datapath/flow.c:201
> 
> 	if (match->mask && (match->mask->key.ipv6.tp.src == htons(0xffff)))
> 
> datapath/flow.c:1437
> 
> 	SW_FLOW_KEY_PUT(match, ipv6.tp.src,
> 		htons(icmpv6_key->icmpv6_type), is_mask);
> 
> Does this address your concern?

Yes, thanks!




More information about the dev mailing list