[ovs-dev] [PATCH 3/4] netlink-socket: Fix handling socket allocation failure in nl_dump_start().

Ben Pfaff blp at nicira.com
Tue Jul 15 17:17:09 UTC 2014


On Tue, Jul 15, 2014 at 04:18:19PM +1200, Joe Stringer wrote:
> On 15 July 2014 09:10, Ben Pfaff <blp at nicira.com> wrote:
> 
> > If nl_pool_alloc() failed, then 'dump' was not initialized at all and
> > further use of the dump would access uninitialized data, probably causing
> > a crash.
> >
> > Found by inspection.
> >
> > Signed-off-by: Ben Pfaff <blp at nicira.com>
> >
> 
> I've glanced sideways at this code a couple of times, but never seen the
> failures. Looks much safer with this patch.
> 
> Acked-by: Joe Stringer <joestringer at nicira.com>

Thanks, I applied this to master, branch-2.3, and branch-2.2.
branch-2.1 and earlier don't have the bug.



More information about the dev mailing list