[ovs-dev] [PATCH] datapath: remove a comment that no longer applies

Andy Zhou azhou at nicira.com
Tue Jul 15 22:03:56 UTC 2014


I sent V2 under a different subject due to the patch content change.
Here is a link to the patch:

http://patchwork.openvswitch.org/patch/4979/

On Mon, Jul 14, 2014 at 5:58 PM, Joe Stringer <joestringer at nicira.com> wrote:
> On 15 July 2014 12:53, Jarno Rajahalme <jrajahalme at nicira.com> wrote:
>>
>>
>> How about this:
>>
>> /* The caller must hold either rcu_read_lock or ovs_mutex to keep the
>> returned dp pointer valid. */
>
>
> This looks good. And I think it's better to have it at get_dp() rather than
> the callers, to help prevent future misuse of the function. Callers who do
> not do this may inadvertently reintroduce a race condition of the type fixed
> in commit 03fc2881382a993 "datapath: Fix race."



More information about the dev mailing list