[ovs-dev] [PATCH] stp: Make stp-disabled port forward stp bpdu packets.

[Alex Wang]

Thx Ben, will add a new column FWD_BPDU as suggested by Joe,

Will add more comments to explain,


On Tue, Jul 15, 2014 at 9:35 PM, Ben Pfaff <blp at nicira.com> wrote:

> On Tue, Jul 15, 2014 at 07:19:53PM -0700, Alex Wang wrote:
> > Commit 0d1cee123a84 (stp: Fix bpdu tx problem in listening state)
> > makes ovs drop the stp bpdu packets if stp is not enabled on the
> > input port.  However, when pif bridge is used and stp is enabled
> > on the integration bridge.  The flow translation of stp bpdu
> > packets will go through a level of resubmission which changes
> > the input port to the corresponding peer port.  Since, the
> > patch port on the pif bridge does not have stp enabled, the
> > flow translation will drop the bpdu packets.
> >
> > This commit fixes the issue by making ovs forward stp bpdu packets
> > on stp-disabled port.
> >
> > VMware-BZ: #1284695
> >
> > Signed-off-by: Alex Wang <alexw at nicira.com>
>
> Fair enough.
>
> Please also update the table in stp.h here:
>
>  *                     FWD  LRN  TX_BPDU RX_BPDU
>  *                     ---  ---  ------- -------
>  *        Disabled      Y    -      -       -
>  *        Blocking      -    -      -       Y
>  *        Listening     -    -      Y       Y
>  *        Learning      -    Y      Y       Y
>  *        Forwarding    Y    Y      Y       Y
>
> Acked-by: Ben Pfaff <blp at nicira.com>
>