[ovs-dev] [PATCH] cmap: Fix cmap_next_position()

Ben Pfaff blp at nicira.com
Wed Jul 16 16:30:09 UTC 2014


On Tue, Jul 15, 2014 at 09:57:55PM -0700, Daniele Di Proietto wrote:
> cmap_next_position() didn't update the node pointer while iterating through a
> list of nodes with the same hash.
> This commit fixes the bug and improve test-cmap to detect it.
> 
> Signed-off-by: Daniele Di Proietto <ddiproietto at vmware.com>

Good catch.

I think that it would be better to always try iterating both ways in
check_cmap(), rather than just one way on each call.  Will you modify
the patch to do that?

Thanks,

Ben.



More information about the dev mailing list